docs: add riot ecosystem plugin #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Oct 12, 2019
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
This is AWESOME! Just a few comments.
| expect(queryByTestId('count').textContent).toBe("10"); | ||
| }) | ||
|
|
||
| test('should add count when click add button text', async () => { |
Member
There was a problem hiding this comment.
Does this test need to be async?
Contributor
Author
There was a problem hiding this comment.
Thanks, this async is unnecessary, I removed it
| import TestTag from './test.tag' | ||
|
|
||
| afterEach(() => { | ||
| cleanup() |
Member
There was a problem hiding this comment.
Have you considered making this cleanup automatic (like React Testing Library)?
Contributor
Author
There was a problem hiding this comment.
This feature is awesome !
I don't pay attention to it when I use react-testing-library. It's easy to use.
I add this feature.
Member
|
@all-contributors please add @ariesjia for docs |
Contributor
|
I've put up a pull request to add @ariesjia! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.